fix: emit rustfmt-compliant #![allow] header - #13
Merged
Conversation
added 2 commits
April 19, 2026 05:14
The single-line `#![allow(dead_code, reason = "…")]` attribute emitted in v0.1.4/v0.1.5 exceeded rustfmt's default 100-col max_width, so `cargo fmt --check` in CI failed on every release and the workflow never uploaded the wasm asset. Pre-wrap the attribute across multiple lines at emit time so the output is idempotent under rustfmt. Regenerate the committed example snapshots and expand the root `sqlc.yaml` to cover all four examples (previously only `basic` was wired up) so `sqlc generate` at repo root keeps every snapshot in sync.
jrandolf-old
pushed a commit
that referenced
this pull request
Apr 19, 2026
🤖 I have created a release *beep* *boop* --- ## [0.1.6](v0.1.5...v0.1.6) (2026-04-19) ### Bug Fixes * Emit rustfmt-compliant #![allow] header ([#13](#13)) ([04acf9a](04acf9a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
jrandolf-old
pushed a commit
that referenced
this pull request
Aug 3, 2026
## Summary - The single-line `#![allow(dead_code, reason = "…")]` attribute the generator emitted in v0.1.4/v0.1.5 exceeded rustfmt's 100-col default, so `cargo fmt --check` failed the release workflow and the v0.1.5 wasm asset was never uploaded. See the failed run: https://github.com/mathematic-inc/sqlc-gen-sqlx/actions/runs/24376376904 - Pre-wrap the attribute across multiple lines at emit time so the output is idempotent under rustfmt. - Regenerate the committed example snapshots and expand the root `sqlc.yaml` so `sqlc generate` covers all four examples (previously only `basic` was wired up). ## Test plan - [x] `cargo fmt --all --check` clean - [x] `cargo clippy --workspace --all-targets -- -D warnings` clean - [x] `cargo test --lib --bins` passes - [x] `cargo build --target wasm32-wasip1` produces a valid plugin - [x] `sqlc generate` with the rebuilt wasm regenerates every example cleanly (sqlc.yaml sha updated to match) Once merged, release-please should open a 0.1.6 PR; merging that will re-trigger `release.yml` with the format check passing and publish the wasm. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
jrandolf-old
pushed a commit
that referenced
this pull request
Aug 3, 2026
🤖 I have created a release *beep* *boop* --- ## [0.1.6](v0.1.5...v0.1.6) (2026-04-19) ### Bug Fixes * Emit rustfmt-compliant #![allow] header ([#13](#13)) ([feed886](feed886)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
jrandolf-old
pushed a commit
that referenced
this pull request
Aug 3, 2026
## Summary - The single-line `#![allow(dead_code, reason = "…")]` attribute the generator emitted in v0.1.4/v0.1.5 exceeded rustfmt's 100-col default, so `cargo fmt --check` failed the release workflow and the v0.1.5 wasm asset was never uploaded. See the failed run: https://github.com/mathematic-inc/sqlc-gen-sqlx/actions/runs/24376376904 - Pre-wrap the attribute across multiple lines at emit time so the output is idempotent under rustfmt. - Regenerate the committed example snapshots and expand the root `sqlc.yaml` so `sqlc generate` covers all four examples (previously only `basic` was wired up). ## Test plan - [x] `cargo fmt --all --check` clean - [x] `cargo clippy --workspace --all-targets -- -D warnings` clean - [x] `cargo test --lib --bins` passes - [x] `cargo build --target wasm32-wasip1` produces a valid plugin - [x] `sqlc generate` with the rebuilt wasm regenerates every example cleanly (sqlc.yaml sha updated to match) Once merged, release-please should open a 0.1.6 PR; merging that will re-trigger `release.yml` with the format check passing and publish the wasm.
jrandolf-old
pushed a commit
that referenced
this pull request
Aug 3, 2026
🤖 I have created a release *beep* *boop* --- ## [0.1.6](v0.1.5...v0.1.6) (2026-04-19) ### Bug Fixes * Emit rustfmt-compliant #![allow] header ([#13](#13)) ([76c2980](76c2980)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#![allow(dead_code, reason = "…")]attribute the generator emitted in v0.1.4/v0.1.5 exceeded rustfmt's 100-col default, socargo fmt --checkfailed the release workflow and the v0.1.5 wasm asset was never uploaded. See the failed run: https://github.com/mathematic-inc/sqlc-gen-sqlx/actions/runs/24376376904sqlc.yamlsosqlc generatecovers all four examples (previously onlybasicwas wired up).Test plan
cargo fmt --all --checkcleancargo clippy --workspace --all-targets -- -D warningscleancargo test --lib --binspassescargo build --target wasm32-wasip1produces a valid pluginsqlc generatewith the rebuilt wasm regenerates every example cleanly (sqlc.yaml sha updated to match)Once merged, release-please should open a 0.1.6 PR; merging that will re-trigger
release.ymlwith the format check passing and publish the wasm.🤖 Generated with Claude Code